Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDISCROWD-7561 Sorting users #969

Merged
merged 13 commits into from
Sep 19, 2024
Merged

RDISCROWD-7561 Sorting users #969

merged 13 commits into from
Sep 19, 2024

Conversation

kbecker42
Copy link

@kbecker42 kbecker42 commented Sep 18, 2024 •
edited
Loading

  • Update tooltip on keyup and paste (when searching).
  • Ignore digits are parenthesis in last names for sorting.

Re: bloomberg/pybossa-default-theme#467

@kbecker42 kbecker42 mentioned this pull request Sep 18, 2024
Merged
@coveralls
Copy link

coveralls commented Sep 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10943121822

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.002%
Totals Coverage Status
Change from base Build 10928560989: 0.0%
Covered Lines: 17318
Relevant Lines: 18423
💛 - Coveralls

n00rsy
n00rsy previously approved these changes Sep 19, 2024
View reviewed changes
Copy link

@n00rsy n00rsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, maybe add tests for cases where fullname has parentheses or digits

@kbecker42 kbecker42 merged commit 8aaa341 into main Sep 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n00rsy n00rsy n00rsy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbecker42 @coveralls @n00rsy